Optimize getEffectivelyEnabledItems per Copilot review - use single loops instead of chained operations

Co-authored-by: AstroSteveo <34114851+AstroSteveo@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-09-23 23:43:32 +00:00
parent 5f58374ea1
commit 0286c46f17

View File

@ -287,23 +287,28 @@ function computeEffectiveItemStates(config) {
function getEffectivelyEnabledItems(config) { function getEffectivelyEnabledItems(config) {
const effectiveStates = computeEffectiveItemStates(config); const effectiveStates = computeEffectiveItemStates(config);
return { const result = {
prompts: new Set( prompts: new Set(),
Object.entries(effectiveStates.prompts) instructions: new Set(),
.filter(([, state]) => state.enabled) chatmodes: new Set()
.map(([itemName]) => itemName)
),
instructions: new Set(
Object.entries(effectiveStates.instructions)
.filter(([, state]) => state.enabled)
.map(([itemName]) => itemName)
),
chatmodes: new Set(
Object.entries(effectiveStates.chatmodes)
.filter(([, state]) => state.enabled)
.map(([itemName]) => itemName)
)
}; };
for (const itemName in effectiveStates.prompts) {
if (effectiveStates.prompts[itemName].enabled) {
result.prompts.add(itemName);
}
}
for (const itemName in effectiveStates.instructions) {
if (effectiveStates.instructions[itemName].enabled) {
result.instructions.add(itemName);
}
}
for (const itemName in effectiveStates.chatmodes) {
if (effectiveStates.chatmodes[itemName].enabled) {
result.chatmodes.add(itemName);
}
}
return result;
} }
module.exports = { module.exports = {